Review of "Harddisk LED NG" version 51.0.0 (1)

Details Page Preview

Show harddisk activity with IO speed and an LED. Click to cycle through display modes.

Extension Homepage
https://github.com/ChrisLauinger77/gnome-shell-extension-HardDiskLEDNG

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:88
    Gio.File.new_for_path("/proc/diskstats").load_contents(null)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:178
            this.ioSpeed = new St.Label({
                text: "---",
                y_align: Clutter.ActorAlign.CENTER,
                style_class: "harddiskledng-label",
            })
  • extension.js:184
            this.ioSpeedIcon = new St.Label({
                text: "",
                y_align: Clutter.ActorAlign.CENTER,
                style_class: "harddiskledng-icon",
            })
  • extension.js:172
            this.ioSpeedStaticIcon = new St.Icon({
                style_class: "system-status-icon",
                y_align: Clutter.ActorAlign.CENTER,
                gicon: Gio.icon_new_for_string("drive-harddisk-symbolic"),
            })
  • extension.js:167
            this.layoutManager = new St.BoxLayout({
                orientation: Clutter.Orientation.HORIZONTAL,
                style_class: "harddiskledng-container",
            })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:193
    this.button.connect("button-press-event", this.changeMode.bind(this))

All Versions

Version Status
51.0.0 (2) Active
51.0.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
Please fix EGO-X-004 mentioned by Shexli. Also, use icons instead of emjoi/ASCII: [Extension Best Practices Guidelines: Icons vs. Emojis](https://gjs.guide/extensions/review-guidelines/best-practices.html#ui-elements-icons-vs-emojis)