Review of "Shell Restart User Menu Entry" version 4

Details Page Preview

A very simple extension that adds a "restart shell" function to the user's menu, with a confirm dialog.

Extension Homepage
https://github.com/asant/gnome-shell-extension-restart-entry

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
16 Active
15 Active
14 Inactive
13 Inactive
12 Inactive
11 Rejected
10 Inactive
9 Rejected
8 Inactive
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Inactive
2 Inactive
1 Inactive

Previous Reviews on this Version

asan posted a review
first attempt to support localizations via json :-)
asan posted a review
uhmm actually I think I should have supported encodings other than utf8...
Jasper St. Pierre posted a review
If you want to reject your own extension, you can do that with the combobox below the "Review" field (well, there should be a combobox you can reject your extension with -- let me know if there isn't)
asan posted a review
Uhm sorry, I can't see the reject combobox... Anyway I found out that json files shall be encoded in unicode formats only ( http://www.ietf.org/rfc/rfc4627.txt , section 3), namely utf8, utf16 (be & le) and utf32 (be & le). Because of this, they can't contain, for instance, ISO-8859-1 encoded strings. This is probably the only true limitation and it would restrict the problem to supporting those formats only. But as far as I know, those encodings should represent the same character sets (utf32 characters are a subset of ucs4 ones, and are the same of utf8), so users could work on utf8 files without problems. What do you think about it?
Jasper St. Pierre posted a review
I'm going to reject this set of extensions. Please just use gettext -- I'm not going to review a bunch of localization and byteshifting code for something that adds "Restart Shell..." to the user menu.