Review of "Resource Monitor" version 3

Details Page Preview

Resource Monitor is a GNOME Shell extension that provides real-time monitoring of key system resources directly in the GNOME Shell top bar. It tracks CPU usage, load average, and temperature; RAM and swap usage; disk stats and space; GPU usage, memory, and temperature; and network activity for both WLAN and Ethernet connections.

Extension Homepage
https://github.com/0ry0n/Resource_Monitor/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

andyholmes posted a review
Thanks for the changes, but your extension still calls `connectSetting()` in `init()` which connects many signals. The handlers for these signals will hold a reference to GSettings object and reference objects that may not even exist if the extension is disabled or uninstalled. For this reason all signals should be connected in `enable()` and the id returned by `GObject.connect()` should be used to disconnect them in `disable()`.
andyholmes rejected
newer version approved