Review "cmus status" version 1 - GNOME Shell Extensions

Review of "cmus status" version 1

Details Page Preview

cmus status

by GregTheMadMonk

Shows cmus status

Extension Homepage: https://github.com/GregTheMadMonk/gnome-cmus-status

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
11	Rejected
10	Active
9	Rejected
8	Active
7	Active
6	Inactive
5	Rejected
4	Inactive
3	Rejected
2	Rejected
1	Rejected

Previous Reviews on this Version

andyholmes rejected July 23, 2019

Your extension looks mostly good, however the function `updateSettings()` is called in `init()` and creates widgets and keybindings. Extensions must not patch gnome-shell, connect signal handlers (ie. keybindings) or create widgets in `_init()`. Please see: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review