Review of "cmus status" version 9

Details Page Preview

Shows cmus status

Extension Homepage
https://github.com/GregTheMadMonk/gnome-cmus-status

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
11 Rejected
10 Active
9 Rejected
8 Active
7 Active
6 Inactive
5 Rejected
4 Inactive
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Rejected because you cannot create objects in init function: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization Move line 685 (extension.js) to enable. 2. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 3. Use ExtensionUtils.getSettings() instead of creating your own custom function: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 4. Also do this on disable: ```js tray = null; gsettings = null; ``` If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions