Review of "Arc Menu" version 31

Details Page Preview

## Unmaintained Project ## This project and all related repositories have been officially archived. Kind Regards - LinxGem33 (Andy C)

Extension Homepage
https://gitlab.com/LinxGem33/Arc-Menu

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

LinxGem33 posted a review
Hi This has been stuck waiting for a review for over a month now, apologies if your short handed or busy but can someone please review this extension at their nearest convenience. kind regards
andyholmes active
Approved. A few notes about Cairo in GJS: * The Cairo bindings in GJS are not perfect, so you need to call `cr.$dispose()` (including the $) when you are done with a Cairo Context or you'll leak a little bit of memory each time. * If it's possible to create a subclass of StDrawingArea, overriding `vfunc_repaint()` performs a little better than connecting to the signal. The function gets a single `cr` argument passed in and `this === StDrawingArea`. * You should probably return `false` from both a signal connection or a vfunc to propagate the event. Usually not returning anything (aka `undefined`) will be coerced to `false`, but that might change one day.
LinxGem33 posted a review
Thanks Andy We will look into that for v32 kind regards