Review "Mute spotify ads" version 1 - GNOME Shell Extensions

Review of "Mute spotify ads" version 1

Details Page Preview

Mute spotify ads

by danigm

Mute spotify ads

Extension Homepage: https://github.com/danigm/spotify-ad-blocker

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
26	Active
25	Active
24	Active
23	Active
22	Active
21	Active
20	Active
19	Active
18	Active
17	Active
16	Rejected
15	Active
14	Active
13	Active
12	Active
11	Active
10	Active
9	Active
8	Active
7	Active
6	Active
5	Active
4	Active
3	Rejected
2	Active
1	Active

Previous Reviews on this Version

andyholmes active September 25, 2019

Looks good. Can you move the class constructor to `enable()` and destroy it in `disable()` for your next version? Since there is no `uninit()` hook in extensions, this reference can never be dropped even if the extension is disabled or uninstalled. If your ad blocker is intended to work when the screen is locked or off and this breaks its functionality, just put comment above the constructor, so reviewers know it is a required exception to the rule.