GNOME Shell Extensions

Review of "Mute spotify ads" version 16

Details Page Preview

Mute spotify ads

by danigm

Mute spotify ads

Extension Homepage
https://github.com/danigm/spotify-ad-blocker
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Rejected
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

danigm auto- active
JustPerfection waiting for author
Where do you remove the timeout in disable (line 95 extension.js)?
danigm posted a review
Just after the first call, in line 100, there's a "return GLib.SOURCE_REMOVE;", this timeout is just to delay the unmute call.
JustPerfection posted a review
> You MUST remove all active main loop sources in disable(), even if the callback function will eventually return false or GLib.SOURCE_REMOVE. https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources Please fix it for the next version.
JustPerfection rejected