Review "shellshape" version 2 - GNOME Shell Extensions

Review of "shellshape" version 2

Details Page Preview

shellshape

by gfxmonk

(DISCONTINUED) A tiling window extension for gnome-shell

Extension Homepage: http://gfxmonk.net/shellshape/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
23	Active
22	Active
21	Rejected
20	Active
19	Active
18	Active
17	Active
16	Active
15	Active
14	Active
13	Active
12	Rejected
11	Active
10	Active
9	Active
8	Active
7	Active
6	Active
5	Active
4	Active
3	Active
2	Active
1	Active

Previous Reviews on this Version

gcampax posted a review May 5, 2012

Hacky indeed... You should at least remove yourself from the icon theme path in disable().

gfxmonk posted a review May 6, 2012

Hmm. Just tried to add that, but it seems that icon theme object doesn't like javascript telling it what to do: > th = imports.gi.Gtk.IconTheme.get_default(); > th.set_search_path(th.get_search_path()) Exception: Unhandled array element type 14. (where should I file that bug? gtk? gobject introspection? or gnome shell?) Leaving this as-is has a pretty minimal consequence: people will be able to use shellshape's three window-tile-*-symbolic icons. They don't override anything, so I think the impact is pretty minimal.

gcampax posted a review May 6, 2012

Oh, right, it's of type filename instead of utf. Bug at gjs. (But I agree it's ok in the mean while)