Review of "Desk Changer" version 17

Details Page Preview

Simple wallpaper changer with multiple profile support. Integrates into the shell by providing it's own panel icon. The daemon is written using gjs and runs independently of the extension as a background process.

Extension Homepage
https://github.com/BigE/desk-changer/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
26 Rejected
25 Active
24 Inactive
23 Inactive
22 Inactive
21 Rejected
20 Rejected
19 Inactive
18 Inactive
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Active
3 Active
2 Rejected
1 Active

Previous Reviews on this Version

andyholmes active
Some notes here: In `prefs.js`, you are not chaining up by calling `super._init()` in `DeskChangerPrefs`. This probably won't matter until the object is destroyed though, since you aren't actually using any features of GObject that I can see. In `daemon/profile.js` you are defining signals in the `GObject.registerClass()` params, but then overwriting them when you call `Signals.addSignalMethods(Profile.prototype)`. You generally want to use one or the other (See: https://gitlab.gnome.org/GNOME/gjs/blob/master/doc/Mapping.md#signals)