Review of "Headphone Event" version 5

Details Page Preview

***Deprecated*** 3.12 has independent volume control. ------------------------------------------- PAUSE playing songs when headphone get unplugged. You can set icon color you like in dconf-editor GS3.8 ✔ GS3.10 support delayed due to my laptop always crash while install it. Can anyone test the code in dev branch on the GIthub Homepage below?

Extension Homepage
https://github.com/mengzhuo/gnome-shell-headphone-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Rejected
4 Active
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

nzjrs posted a review
- if ( this._cardDevices[i].indexOf("Headphone Jack") > 0 ){ + if ( this._cardDevices[i].indexOf(HeadPhoneJACK) >= 0 ){ ?? where is HeadPhoneJACK ?? You have added a blacklist.json file. Please use gsettings to store such information
Meng Zhuo posted a review
@nzjrs > ?? where is HeadPhoneJACK ?? HeadPhoneJACK is a const and be defined in the head section. > You have added a blacklist.json file. Please use gsettings to store such information Extension "panel-docklet@quina.at" use this way to store user-setting too, why can't I use the same way? Besides, Gsetting is hard to maintain (need re-compile every time when packing extension) and debug for it is an total disaster. For such little amount of data storage I think json is much more appropriate.
nzjrs posted a review
Software is hard. Please use gsettings.