Review of "clippie [replaced by eclipse]" version 3

Details Page Preview

clippie has been rereleased as 'eclipse' Clipboard interface to gpaste-client output https://extensions.gnome.org/extension/4246/eclipse/ Clippie now uses dbus to communicate with the gpaste daemon Added encryption of clipboard items with eclipse feature

Extension Homepage
https://github.com/blackjackshellac/eclipse

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Rejected
4 Inactive
3 Inactive
2 Inactive
1 Rejected

Previous Reviews on this Version

andyholmes active
You should attach a `.catch()` to the end of your Promise at line #191 of extension.js. If the promise rejects it will float around in the main context forever.
steeve.mccauley posted a review
Andy, thanks for the review. I'm confused though, because I don't have a Promise at #191 of extension.js, there is one in utils.js but it has a catch.
andyholmes posted a review
Oh I see, I didn't notice it was wrapped in a try...catch. Should be okay then :)
steeve.mccauley posted a review
It's already gone in the github version, I'm using dbus now rather than spawning gpaste-client