Review of "clippie [replaced by eclipse]" version 6

Details Page Preview

clippie has been rereleased as 'eclipse' Clipboard interface to gpaste-client output https://extensions.gnome.org/extension/4246/eclipse/ Clippie now uses dbus to communicate with the gpaste daemon Added encryption of clipboard items with eclipse feature

Extension Homepage
https://github.com/blackjackshellac/eclipse

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Rejected
4 Inactive
3 Inactive
2 Inactive
1 Rejected

Previous Reviews on this Version

andyholmes active
It would probably be a good idea to move Clippy into a subprocess that can be manually disabled if possible. Currently it can never be turned off, even if the extension is uninstalled.
steeve.mccauley posted a review
How can I detect if an extension has been uninstalled? I probably no longer need clippie running as a singleton instance, I'll look into just re-instantiating normally when the indicator is created. Note that I rebranded as 'eclipse' because I'm focusing on the ability to encrypt clipboard entries, thus the name/uuid change. Thanks again.
andyholmes posted a review
There is really is no way to reliably detect when an extension has been uninstalled. This is in fact the reason we disallow the creation of anything in `init()` or the top-level of imports, because there is no `uninit()` call. There are some cases, such as a drop down terminal, where the main functionality must continue running after `disable()` is called, and that's why we make an allowance for subprocesses. Those are an acceptable compromise because they run outside of the gnome-shell process.
steeve.mccauley posted a review
Okay, we'll for now I've detected when the indicator is destroyed and have detached the Clippie process and reduced any memory impact. I did some work on it today and it's now stateless so I'm going to refactor it to remove the singleton object and allow it to be re-instantiated when the indicator is recreated. Thanks for the review.