Review of "Shu Zhi" version 11

Details Page Preview

Wallpaper generation extension for GNOME Shell, inspired by jizhi For support, please report any issues via the homepage link below.

Extension Homepage
https://github.com/tuberry/shuzhi

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Preferences dialog has error and cannot be open. 2. On prefs.js file remove `GLib.idle_add(GLib.PRIORITY_DEFAULT_IDLE, () => {` and use realize instead: https://gjs.guide/extensions/upgrading/gnome-shell-40.html#get-prefs-window-and-resize-it
grroot posted a review
I can open the prefs dialog, so what's the error?
JustPerfection posted a review
TypeError: GObject.ParamSpec.jsobject is not a function Stack trace: @/home/ice/.local/share/gnome-shell/extensions/shuzhi@tuberry/ui.js:94:39 @/home/ice/.local/share/gnome-shell/extensions/shuzhi@tuberry/prefs.js:12:12 _init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:206:33 OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28 asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:132:22 run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20 main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13 run@resource:///org/gnome/gjs/modules/script/package.js:222:19 start@resource:///org/gnome/gjs/modules/script/package.js:206:8 @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17 and Error: Type name Gjs_shuzhi_tuberry_UI_FileButton is already registered Stack trace: _init/GObject.Object._classInit@resource:///org/gnome/gjs/modules/core/overrides/GObject.js:451:27 _init/Gtk.Widget._classInit@resource:///org/gnome/gjs/modules/core/overrides/Gtk.js:92:32 registerClass@resource:///org/gnome/gjs/modules/core/overrides/GObject.js:95:22 @/home/ice/.local/share/gnome-shell/extensions/shuzhi@tuberry/ui.js:11:26 @/home/ice/.local/share/gnome-shell/extensions/shuzhi@tuberry/prefs.js:12:12 _init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:206:33 OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28 asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:132:22 run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20 main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13 run@resource:///org/gnome/gjs/modules/script/package.js:222:19 start@resource:///org/gnome/gjs/modules/script/package.js:206:8 @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17
grroot posted a review
1. `jsobject` is the new API in gjs 1.67.2, see https://gitlab.gnome.org/GNOME/gjs/-/blob/master/modules/core/overrides/GObject.js#L344 2. GTypeName is generally unique in the code, so there might be more than one extension instance running.
grroot posted a review
I don't know how to fix that because it's not reproducible for me with GNOME Shell 40.1 / gjs 1.68.0.
JustPerfection active
Changed to approved since the preferences dialog can be open on Fedora 34 beta. Please remove `GLib.PRIORITY_DEFAULT_IDLE` for the next version. It's racy. Change it to `realize` as we have it on the port guide.
grroot posted a review
Thanks, I know it's racy but should not hurt anything. I will change that in the next version.