Review of "Vitals" version 42

Details Page Preview

A glimpse into your computer's temperature, voltage, fan speed, memory usage, processor load, system resources, network speed and storage stats. This is a one stop shop to monitor all of your vital sensors. Uses asynchronous polling to provide a smooth user experience. Feature requests or bugs? Please use GitHub.

Extension Homepage
https://github.com/corecoding/Vitals

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection active
1. Lang is a deprecated module. Please remove it for the next version: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#General_Advice You can use GObject instead: https://gjs.guide/guides/gjs/legacy-class-syntax.html#comparison-between-legacy-and-es6-implementations 2. It's better to use imports in global scope. For example, move `MenuItem = Me.imports.menuItem;` out of extension.js->init . 3. Just to have files in correct folders, you should move .ui file out of schemas folder. schemas folder shouldn't have .ui file since schema and UI are completely different things. btw, schemas folder has special meaning for an extension package since they can hold compiled and source files of schema. Please join us on GNOME Matrix channel, you can always ask questions related to the extensions there: https://matrix.to/#/#extensions:gnome.org
corecoding posted a review
Thank you for this valuable input. Can you point me to a page or example project that shows the replacement for Lang.bind?
JustPerfection posted a review
Lang to GObject example: https://gjs.guide/guides/gjs/legacy-class-syntax.html#comparison-between-legacy-and-es6-implementations Please join us on GNOME Matrix channel if you need more help: https://matrix.to/#/#extensions:gnome.org