Review of "gSnap" version 4

Details Page Preview

Organize windows in customizable snap zones like FancyZones on Windows.

Extension Homepage
https://github.com/GnomeSnapExtensions/gSnap

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
24 Active
23 Active
22 Active
21 Rejected
20 Rejected
19 Active
18 Rejected
17 Rejected
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Rejected
9 Active
8 Rejected
7 Rejected
6 Active
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Rejected because you are still creating object in global scope: const mySettings = Settings.get(); should be in enable(). btw, since you are only supporting GNOME Shell 40 now, 1. You can remove settings.js file and use this instead: const ExtensionUtils = imports.misc.extensionUtils; let settings = ExtensionUtils.getSettings(); 2. Lang is a deprecated module. Please remove it for the next version: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#General_Advice You can use GObject instead: https://gjs.guide/guides/gjs/legacy-class-syntax.html#comparison-between-legacy-and-es6-implementations Learn more about removing Lang: https://wiki.gnome.org/Projects/GnomeShell/Extensions/MigratingShellClasses