Review of "gSnap" version 8

Details Page Preview

Organize windows in customizable snap zones like FancyZones on Windows.

Extension Homepage
https://github.com/GnomeSnapExtensions/gSnap

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
24 Active
23 Active
22 Active
21 Rejected
20 Rejected
19 Active
18 Rejected
17 Rejected
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Rejected
9 Active
8 Rejected
7 Rejected
6 Active
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

themeronz posted a review
Hello! New uploader here. I've applied the requested changes. Let me know if everything is okay now.
JustPerfection rejected
Hi, 1. Remove layouts-default.json: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 2. Why don't you use this instead of `getCurrentPath()` (line 26 extension.js)? ```js const path = ExtensionUtils.getCurrentExtension().path(); ``` 3. Remove line 310 and 302 (prefs.js). GNOME Shell internals should call those functions. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
themeronz posted a review
Layouts-default is used the first time the extension loads and then every time the layouts.json is unreadable for some reason. It is not useless. Couldn’t you let this pass? Ok for points 2 and 3.
JustPerfection posted a review
Ok, send it with `layouts.json`.
themeronz posted a review
`layouts.json` is the name of the user's current settings. Changing it will break the user configuration when the extension will upgrade. To summarize: - layouts-default.json: shipped with the extension, unchanged by the user. - layouts.json: created on first extension startup, changed on user-requested changes (through the editor). Restored on corruption from layouts.json.
JustPerfection posted a review
Oh! I typed the wrong filename there (sorry! I'm reviewing while working). I mean you can send it with `layouts-default.json` and only fix #2 and #3.