Review of "Docker Shortcut" version 1

Details Page Preview

Docker containers manager

Extension Homepage
https://github.com/DanielGustavo/Docker-Shortcut

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active
1. Please fix this warning for the next version (You can see that with `journalctl -f`): Usage of object.actor is deprecated for Menu get@resource:///org/gnome/shell/ui/environment.js:287:29 _init@/home/ice/.local/share/gnome-shell/extensions/dockershortcut@danielgustavo5205.gmail.com/src/components/Menu.js:19:5 _init@/home/ice/.local/share/gnome-shell/extensions/dockershortcut@danielgustavo5205.gmail.com/src/ui/Menu.js:11:11 enable@/home/ice/.local/share/gnome-shell/extensions/dockershortcut@danielgustavo5205.gmail.com/extension.js:6:17 _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:167:32 _onEnabledExtensionsChanged/<@resource:///org/gnome/shell/ui/extensionSystem.js:499:18 _onEnabledExtensionsChanged@resource:///org/gnome/shell/ui/extensionSystem.js:498:11 _init/createCheckedMethod/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:529:46 enableExtension@resource:///org/gnome/shell/ui/extensionSystem.js:194:29 EnableExtension@resource:///org/gnome/shell/ui/shellDBus.js:307:38 _handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:327:38 _wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:404:34 2. Log should only be available on debug mode: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#No_excessive_logging 3. src/components/BaseMenu.js has unnecessary signal on line 7-9 and 26. Please remove that for the next version. You can always ask questions related to the extensions by joining us on GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org
Daniel Gustavo waiting for author
Hi, So I've fixed both the first and second problems in the next coming version. However, I couldn't really understand the third problem. Line 7-9 in "src/components/BaseMenu.js" are just parameters being passed in the class "PopupMenuItem". And line 26 in "src/components/BaseMenu.js" is where the parameter "onClick" of the method "addButton" is being passed in the event "activate" of a "PopupMenuItem", besides that, the method "onClick" will be registered in the event "activate" only when the method "addButton" is executed. The method "addButton" is being used in "src/ui/ContainerSubMenu.js" in line 35, for example. That said, I'm not sure of what I should do about this third problem which you pointed out once I can't identify it. I'm a beginner at GNOME extensions development, so please forgive me if I'm not noticing an obvious mistake.
JustPerfection posted a review
oh! I meant 17-19 which is: 17 onClick = () => { 18 log('clicked'); 19 }, and 26 button.connect('activate', onClick); That onClick only logs 'clicked' which means the button does nothing.
JustPerfection rejected