Review of "Docker Shortcut" version 2

Details Page Preview

Docker containers manager

Extension Homepage
https://github.com/DanielGustavo/Docker-Shortcut

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Rejected because you are creating objects in global scope which is the same as init ("const settings = getSettings();"): https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Only_use_.60init.28.29.60_for_initialization Please remove that. You can use dependency injection that comes from enable() or buildPrefsWidget(). In that case, you only create settings object once. 2. Please remove `src/utils/getSettings.js`. You can use this instead: const ExtensionUtils = imports.misc.extensionUtils; and add this to metadata.json: "settings-schema": "org.gnome.shell.extensions.dockershortcut", in enable() or buildPrefsWidget(): let settings = ExtensionUtils.getSettings();