Review "Dark Variant" version 1 - GNOME Shell Extensions

Review of "Dark Variant" version 1

Details Page Preview

Dark Variant

Enable dark window decorations on applications. This extension is not compatible with applications that use Client Side Decorations (CSD). This extension depends on some Xorg utilities. To install them: - Debian/Ubuntu: apt install x11-utils - Fedora/RHEL: dnf install xorg-x11-utils - Arch: pacman -S xorg-xprop *Settings are provided to enable/disable applications.

Extension Homepage: https://github.com/hardpixel/dark-variant

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
10	Active
9	Active
8	Active
7	Active
6	Active
5	Rejected
4	Active
3	Active
2	Active
1	Active

Previous Reviews on this Version

JustPerfection active September 12, 2021

I see you are using `ExtensionUtils.getSettings()` and `Convenience.getSettings()` which is redundant. You shouldn't create multiple instances of settings in each class. Create it once on enable() or buildPrefsWidget() and then use dependency injection. Anyway, please remove `convenience.js` for the next version. You can use these instead: ExtensionUtils.initTranslations(); let settings = ExtensionUtils.getSettings();

hardpixel posted a review September 12, 2021

Thanks for the tips @JustPerfection and for being so fast in reviews! I have submitted a new version with your suggestions.

JustPerfection posted a review September 12, 2021

Thanks.