Review of "Shortcuts" version 7

Details Page Preview

This shows a pop-up of useful keyboard shortcuts when Ctrl + Alt + Super + S is pressed (hotkey can be changed in settings)

Extension Homepage
https://gitlab.com/paddatrapper/shortcuts-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
46.1 (26) Active
46.0 (25) Inactive
45.0 (24) Inactive
23 Inactive
22 Inactive
21 Inactive
20 Inactive
19 Inactive
18 Rejected
17 Inactive
16 Rejected
15 Active
14 Inactive
13 Inactive
12 Rejected
11 Inactive
10 Inactive
9 Rejected
8 Rejected
7 Rejected
6 Inactive
5 Rejected
4 Inactive
3 Inactive
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Rejected because you cannot create objects in init function. both in extension.js and prefs.js. Move those objects to enable() and buildPrefsWidget() functions: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Only_use_.60init.28.29.60_for_initialization 2. Remove all .po, .pot and LINGUAS files: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Don.27t_include_unecessary_files 3. Lang is a deprecated module. Please remove it for the next version (you need to remove shell-version older than 3.36 for that): https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#General_Advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 4. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (3.36 and higher): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js You need to remove convenience.js after that. 5. Remove Mainloop import in extension.js since you are not using it. If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions