Review of "Movie Search provider for Synology®" version 10

Details Page Preview

search provider for movie titles on Synology® NAS including offline search (yet to come)

Extension Homepage
https://github.com/psasse72/movies4synology

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
14 Active
13 Active
12 Active
11 Rejected
10 Rejected
9 Active
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Waiting for author
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create objects in global scope which is the same as init (line 62 extension.js): https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Only_use_.60init.28.29.60_for_initialization to fix that, you need to move that line to enable(). Also move everything in init() (prefs.js) to extension.js. 2. Remove getSettings function in extensions.js. 3. Lang is a deprecated module. Please remove it for the next version: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#General_Advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 4. Remove unnecessary `Shell` import in extension.js. 5. Remove `get_schema()` function. use ExtensionUtils.getSettings instead. If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
JustPerfection posted a review
I made a typo in the review. Edit: * Also move everything from init() (prefs.js) to buildPrefsWidget(). ^~~~~~~~~~~~~~