Review of "Hotkeys Popup" version 1

Details Page Preview

Pop-up cheatsheet with currently configured keyboard shortcuts.

Extension Homepage
https://github.com/mipmip/gnome-shell-extensions-highlight-focus

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Active
8 Rejected
7 Rejected
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove all .po an .pot files: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 2. Remove convenience.js file. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 3. line 366-375 (extension.js), line 47-49 (prefs.js) shouldn't be there since you are supporting 40 and higher. 4. Remove Lang import in prefs.js 5. Use arrow function instead of `function (){ }.bind(this)`. () => { // this will be available here } 6. Find better alternative for `listkeys.sh`. It's better to get the values with specific key one by one. const Gio = imports.gi.Gio; let keybindingsSettings = new Gio.Settings({ schema: 'org.gnome.desktop.wm.keybindings' }); let keybindingsKeys = [ 'activate-window-menu', 'begin-move', ... ]; Now you can loop through `keybindingsKeys` and find the values from `keybindingsSettings`.
JustPerfection posted a review
If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Pim Snel posted a review
Thanks for the great feedback. Specially the tips to program with GSettings. I took the time and followed your directions. I also installed a eslint to cleanup more code. I re-implemented the keybinding following your youtube tutorial.