Pop-up cheatsheet with currently configured keyboard shortcuts.
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
1. Rejected because you are calling `centerBox()` at the end of `_readShortcuts()`. That can cause so many warnings (`journalctl -f`) since you haven't created the `stage` widget yet. To fix that you need to call `centerBox()` at the end of `_showPopup()`. 2. Why are you using `this._settings` instead of `_settings`? 3. It's expensive on the resources to do this every time: if(!this._settings){ this._settings = ExtensionUtils.getSettings(); } That's not a good practice. If you want to use that approach, you can do this instead: function getSettings() { if (!_settings) { _settings = ExtensionUtils.getSettings(); } return _settings; } now you can use that function anywhere you want without duplicating too much. Or maybe you go with the more simple approach: in enable(): _settings = ExtensionUtils.getSettings(); and use it in any other places without checking. 4. You should also destroy and null every widget you created on disable(). Including: button, stage, panel_panel, left_panel, right_panel, super_label Just check it like this and null those: if (stage) { stage.destroy(); stage = null; } I know you are doing that on `_hidePopup()` but we need that on disable() too. btw, you can also ask us about approval before sending the package here: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Thanks again. I'm learning a lot from your feedback. I'll try to fix these directions now.