Review of "Notification Banner Position" version 3

Details Page Preview

Changes position of the notification banner from the default to the right side of the screen.

Extension Homepage
https://github.com/brunodrugowick/notification-position-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
18 Active
17 Active
16 Rejected
15 Active
14 Active
13 Active
12 Active
11 Rejected
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection active
It's better to store the original values in init() or enable(), then revert it to that value in disable(). I also recommend to use `messageTray.bannerAlignment` instead. You can see how I'm doing it in my own extension: https://gitlab.gnome.org/jrahmatzadeh/just-perfection/-/blob/e09f39863e644e8ed4024d25f6b3f3c9104057f1/src/lib/API.js#L1995-2017
JustPerfection posted a review
If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Bruno Drugowick posted a review
Hey, only now I'm seeing these messages here. Thanks, I'll take a look at the links provided.