Review of "asusctl-gex" version 2

Details Page Preview

Current version is not feature complete with the current asusctl version so I set the extension as inactive for the time being. We currently don't have the time to update and maintain it. Please use ROG Control Center at the moment. --- asusctl-gex is a frontend for some functionalities of asusctl and supergfxctl that were born inside the asus-linux.org community. asusctl is required. To learn more about it, please have a look at: https://gitlab.com/asus-linux/asusctl https://gitlab.com/asus-linux/asusctl-gex https://asus-linux.org/


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please fix those issues I mentioned in version 1 and send it again. 2. You should remove any timeout you are creating: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources only nulling them out isn't enough. Line 89 (modules/charge_dbus.js). 3. Please remove `.back` files: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 4. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions