Review of "asusctl-gex" version 5

Details Page Preview

Current version is not feature complete with the current asusctl version so I set the extension as inactive for the time being. We currently don't have the time to update and maintain it. Please use ROG Control Center at the moment. --- asusctl-gex is a frontend for some functionalities of asusctl and supergfxctl that were born inside the asus-linux.org community. asusctl is required. To learn more about it, please have a look at: https://gitlab.com/asus-linux/asusctl https://gitlab.com/asus-linux/asusctl-gex https://asus-linux.org/


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

Marco Laux posted a review
This is a hotfix. After removing everything from the constructor() to enable() a problem accured that the indicator was not destroyed after locking the screen. So now I catch this with a try. Not sure if this is the right way but this behaviour will be improved in the future.
JustPerfection waiting for author
I don't think that's a good approach to have it in try catch block. `this.panelButton.destroy()` should release all the dependencies. What is the error you are getting in `journalctl -f`? Do this on disable: ```js if (this.panelButton) { this.panelButton.destroy(); this.panelButton = null; } ```
Marco Laux posted a review
it's added and I submitted a new file
JustPerfection waiting for author
Ok but do you want to remove that try catch block too?
Marco Laux posted a review
oh yes ;) but with our previous panel button construct it did also not get destroyed completely. I had to contruct the panel button differently than I did previously. This time it gets destroyed successfully. Thank you - this should now be compliant.
JustPerfection rejected
Newer version approved.