Review of "Internet Speed Monitor" version 1

Details Page Preview

Extension to Monitor Internet Speed and Daily Data Usage minimally. It is a fork of InternetSpeedMeter

Extension Homepage
https://github.com/rishuinfinity/InternetSpeedMonitor

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Rejected
8 Active
7 Active
6 Active
5 Active
4 Active
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Move everything from init to enable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Destroy and null the container on disable: if (container) { container.destroy(); container = null; } 3. Remove last file: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
rishuinfinity waiting for author
Hi, This is my first time making an extension so thanks for the review. I have made the changes w.r.t. points 1 and 2. > But I need a file named last in the same src folder to save data used value and last reset date. It can even be empty in the beginning. I tried creating an empty file in enable/init but I am having a hard time figuring that out. So, Q : Can I put an empty file named "last" in the src folder? If not, how can I create an empty file in enable? Q : Do I need to resend the extension for review after making these changes?
JustPerfection posted a review
- Yes you can create an empty file if you need that. - You can send the new version by uploading the same way you sent this one.
JustPerfection rejected