Review of "Internet Radio" version 16

Details Page Preview

Listen to an Internet Radio Stream

Extension Homepage
https://github.com/hslbck/gnome-shell-extension-radio

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please remove all .po and .pot files: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 2. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
hslbck posted a review
Regaring 2.) Files seems to show only deleted files in this review. Not sure why, but in review for version 15 files list looks ok. ExtensionUtils already used by the extension and convencie.js removed a long time ago
JustPerfection posted a review
I checked your git repo. You are doing too much for creating the package. Use my script to create the package for here: https://gitlab.gnome.org/jrahmatzadeh/just-perfection/-/blob/main/scripts/build.sh make sure you have correct `--podir` and `--extra-source` if needed. don't include po folder in `--extra-source`. Also check the zip file before sending it here. You can also come to GNOME Matrix channel and show me the package before sending it here.