Review of "Internet Radio" version 22

Details Page Preview

Listen to an Internet Radio Stream

Extension Homepage
https://github.com/hslbck/gnome-shell-extension-radio

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Don't use `var`. Use `let` and `const` instead. Use `export class` when you want to export class. 2. No need to use `this.initTranslation()`: > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. [Port Guide 45: Extension Utils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 3. GNOME Shell uses soup 3, no need to specify the version (line 16 `prefs.js`). 4. You cannot import `Gtk` to the GNOME Shell process (line 16 `radioMenu.js`): [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell) 5. Anything you create on global scope should be destroyed and null out on disable or window close: - line 35-42 `prefs.js` - line 39, 74, 75 `radioMenu.js` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 6. Please remove `Gst` from `player.js` and use this to play the sound instead: ```js let player = global.display.get_sound_player(); let file = Gio.File.new_for_path('PATH TO THE FILE'); player.play_from_file(file, 'title', null); ``` Or play audio form theme: ``` player.play_from_theme('sound name', 'title', null); ```