Review of "Sane Airplane Mode" version 1

Details Page Preview

Make airplane mode sane again! This extension gives you better control over the airplane mode and lets you turn off the annoying "Bluetooth gets turned on when I disable airplane mode" behaviour.

Extension Homepage
https://github.com/AntiKippi/gnome-shell-extension-sane-airplane-mode

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2.0.1 (14) Active
2.0.0 (13) Active
12 Active
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Inactive
5 Inactive
4 Inactive
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Kippi posted a review
Works for me
JustPerfection rejected
1. Line 64 (extension.js) timeout should be removed on disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 2. Use ExtensionUtils.getSettings() instead of creating your own custom function: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 3. Do not import prefs.js file inside extension.js. That file contain gtk and shouldn't be used like that in GNOME Shell source code. If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Kippi posted a review
1. I don't quite get why I need to remove this, this is a one-shot timeout used as time delay and will only run once. But anyways, I am removing it directly after the timeout now. 2 and 3: Good point, I found this code on another extension here and thought this would be a good practice. Please review again.
JustPerfection posted a review
For #1: The timeout callback can get triggered in lock screen after your extension get disabled. We don't want that for security reason.