Review of "Sane Airplane Mode" version 3

Details Page Preview

Make airplane mode sane again! This extension gives you better control over the airplane mode and lets you turn off the annoying "Bluetooth gets turned on when I disable airplane mode" behaviour.

Extension Homepage
https://github.com/AntiKippi/gnome-shell-extension-sane-airplane-mode

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2.0.1 (14) Active
2.0.0 (13) Active
12 Active
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Inactive
5 Inactive
4 Inactive
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Kippi posted a review
Fixed #1 now, please review again.
JustPerfection rejected
1. Rejecting this one because you are pushing timeouts to the array without emptying the array on disable. On next disable it will go through those removed timeouts again and again. Users will have so many warnings in the log saying those ids are removed before. 2. Remove try catch block inside `setTimeout` function. Returning false will remove the timeout but you should do `timeoutId = null` before returning false. Also On disable: saneAirplaneMode = null; if (timeouts[i]) { GLib.Source.remove(timeouts[i]); }
Kippi posted a review
Huh okay, I thought all those stuff will be automatically cleaned up. Also, the timeout should only contain the id values which shouldn't be undefined so I thought this if check would be redundant. Anyways I've moved this now into the destroy method and setting everything to null. And if when I return false the timeout gets removed automatically I don't need to remove it manually so I deleted this code also.