Review of "Alternate Menu for Hplip" version 14

Details Page Preview

control your hp printers by calling the device manager hp-toolbox, also some useful links Motivation: the hp-systray doesn't work reliably under gnome shell you need to have installed hplip in order to use this Choice of using a printer icon or a hp_logo.png if it's installed in the same place as mine on Ubuntu you could use symbolic links to fake the path.


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
16 Rejected
15 Rejected
14 Rejected
13 Rejected
12 Rejected
11 Active
10 Active
9 Rejected
8 Rejected
7 Active
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Uncomment line 25 (extension.js). 2. Move line 174 to enable. You cannot create objects in init function: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 3. Also do these on disable: settingsJSON = null; extension = null; 4. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 5. Remove compile.sh, compileif.sh, .pot and .po files: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 6. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions