Review "No Titlebar When Maximized" version 1

Review of "No Titlebar When Maximized" version 1

Details Page Preview

No Titlebar When Maximized

by alecdotninja

Hides the classic title bar of maximized X.Org windows

Extension Homepage: https://github.com/alecdotninja/no-titlebar-when-maximized

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
19	Active
18	Active
17	Rejected
16	Rejected
15	Active
14	Active
13	Rejected
12	Rejected
11	Active
10	Active
9	Inactive
8	Inactive
7	Active
6	Active
5	Active
4	Active
3	Active
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected November 26, 2021

1. You cannot create objects and connect signals in the constructor of the class that init returns. https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization Move line 12 to 21 to enable. 2. Please answer this for the next version: Is this extension a fork? If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions

alecdotninja posted a review November 26, 2021

1. The `Listener` class actually does not connect any signals until `enabled` is called. I'll refactor to make that more obvious. 2. This extension is not a fork. I referenced the source code of some other extensions (mainly Pixel Saver) while writing it, but it was written from scratch.

JustPerfection posted a review November 26, 2021

Thanks. Approved the new version.