Review of "No Titlebar When Maximized" version 16

Details Page Preview

Hides the classic title bar of maximized X.Org windows

Extension Homepage
https://github.com/alecdotninja/no-titlebar-when-maximized

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
16 Rejected
15 Active
14 Active
13 Rejected
12 Rejected
11 Active
10 Active
9 Inactive
8 Inactive
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Please remove `session-modes` and send it again.
alecdotninja posted a review
This was requested by a user of the extension because it resolves an issue that he is having in Fedora (see https://github.com/alecdotninja/no-titlebar-when-maximized/pull/22). Is there a better way to solve this issue?
JustPerfection posted a review
You shouldn't use `session-modes` for that. Even with session modes, disable MAY get called on lock because GNOME Shell is re-basing. [EGO Review Guidelines: Session Modes](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#session-modes) Maybe monitoring the updated signal can help: ```js this._sessionId = Main.sessionMode.connect('updated', () => { this._forEachWindow((window) => { this._sync(window); }); }); ```