Review of "End Session Timer" version 6

Details Page Preview

Set end session timer in seconds

Extension Homepage
https://github.com/PRATAP-KUMAR/end-session-timer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
13 Active
12 Inactive
11 Rejected
10 Rejected
9 Rejected
8 Active
7 Active
6 Rejected
5 Inactive
4 Inactive
3 Inactive
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
Why don't you remove it with `GLib.Source.remove()` ?
PRATAP PANABAKA posted a review
I am Sorry, I am not sure, how to do that. Is this Ok? ```` disable() { imports.ui.endSessionDialog.EndSessionDialog.prototype._sync = A; GLib.source_remove(this._timerId); imports.ui.endSessionDialog.EndSessionDialog.prototype._startTimer = B; } ````
JustPerfection posted a review
Yes. That's ok but you should also check whether the timeout id exist. So, from your example, this is the correct one: ```js disable() { imports.ui.endSessionDialog.EndSessionDialog.prototype._sync = A; if (this._timerId) { GLib.source_remove(this._timerId); } imports.ui.endSessionDialog.EndSessionDialog.prototype._startTimer = B; } ```
JustPerfection rejected
I'm going to reject this one, please send it again once you fixed the timeout.