Review of "End Session Timer" version 9

Details Page Preview

Set end session timer in seconds

Extension Homepage
https://github.com/PRATAP-KUMAR/end-session-timer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
13 Active
12 Inactive
11 Rejected
10 Rejected
9 Rejected
8 Active
7 Active
6 Rejected
5 Inactive
4 Inactive
3 Inactive
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Timeout should be removed on disable (line 41 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 2. What is `C_()` in `data.js`?
PRATAP PANABAKA posted a review
Hi @JustPerfection, Thanks for your review. 1. Timeout, Oh sorry I will remove it. 2. C_() are something like `_`, `gettext`, `ngettext`, `pgettext`. I find it difficult to import them into the `data.js` file. I will refactor the code in a few hours and send it for review. Thanks again.
PRATAP PANABAKA posted a review
Hi @JustPerfection. I did make trails with creating that data in extension itself and used gettext, ngettext and pgettext in place of `C_()`, `_`, `ngettext`. This way the extension needs to have its own translations. The constants in `data.js` file are copy of constants from resources `endSessionDialog.js` file. When I keep `C_()`, `_` and `ngettext` as it is in `data.js` file, evethough there are linter errors on these three, the translations are automatic and the extension is working fine. Theses translations are huge advantage. I tried couple of hours and found this is the best way for automatic translations. I have removed the timeout and submitting for your review. Thanking You.