Review of "Countdown & Timer" version 4

Details Page Preview

Countdown in minutes, or enter text containing HH:MM format to set the Timer.

Extension Homepage
https://github.com/eexpress/gnome-shell-countdown-timer/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Active
8 Inactive
7 Rejected
6 Inactive
5 Inactive
4 Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

eexpss posted a review
v 4 add sound
JustPerfection waiting for author
Please don't use spawn command for playing sound. Use SoundPlayer instead: https://gjs-docs.gnome.org/meta9~9_api/meta.soundplayer#method-play_from_file ```js let player = global.display.get_sound_player(); let file = Gio.File.new_for_path('PATH TO THE FILE'); player.play_from_file(file, 'title', null); ``` or you can play sound from theme: https://gjs-docs.gnome.org/meta9~9_api/meta.soundplayer#method-play_from_theme You wanna fix that and send it again?
eexpss posted a review
``` player.play_from_theme('complete', 'countdown', null); ``` This works well. I don't want add a ogg file to my extension, so I choose `play_from_theme`. I want paly 3 or more times, but I don't know if the `global.display.get_sound_player()` would block the gnome shell thread. Can I loop 3 times here?
JustPerfection waiting for author
Why you wanna do that? That's the sound from theme and users don't expect to have that playing 3 times. Maybe instead of `complete` use `alarm-clock-elapsed`. If you loop, you will end up overlapping because you don't know how long the `complete` sound will be since users can change the sound theme.
eexpss posted a review
I have solved this, but I am not familiar with the submission process. I need submit another zip here? still version 4. BTW: I want entire delete https://extensions.gnome.org/extension/4717/at-gui/, this is an mistake extension.
JustPerfection posted a review
1. Version is auto increment. You cannot submit version 4 again. Next version will be 5. 2. I rejected that as you requested: https://extensions.gnome.org/review/28744
JustPerfection waiting for author
eexpss posted a review
thanks, I had submit version 5. pls reject version 4.
JustPerfection rejected