Review of "Clip Note" version 7

Details Page Preview

Save clip contents to multiple notes with separate tags. Notes locate at ~/.local/share/clip-note/. Dots in filename means splited tags.

Extension Homepage
https://github.com/eexpress/gnome-shell-clip-note

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
11 Active
10 Inactive
9 Inactive
8 Inactive
7 Rejected
6 Inactive
5 Inactive
4 Inactive
3 Rejected
2 Inactive
1 Inactive

Previous Reviews on this Version

eexpss posted a review
many message in log ``` setup_framebuffers: assertion 'width > 0' failed setup_framebuffers: assertion 'width > 0' failed ``` I don't know why.
eexpss posted a review
⭕ ag clip-note /var/log/syslog|grep 'Jan 25'|egrep -v '===clip-note===|JS ERROR|inflating|extracting|ignoring null'|wc -l 0 ⭕ ag clip-note /var/log/syslog|grep 'Jan 25'|egrep -v '===clip-note===|JS ERROR|inflating|extracting' 78637:Jan 25 15:36:55 eexpss-R720 org.gnome.Nautilus[4818]: Warning: : ignoring null tag in /home/eexpss/.local/share/gnome-shell/extensions/clip-note@eexpss.gmail.com/extension.js(line: 8) ⭕ ag setup_framebuffers /var/log/syslog|grep 'Jan 25'|wc -l 130 ⭕ ag setup_framebuffers /var/log/syslog|grep 'Jan 25'|tail -n 2 78883:Jan 25 15:47:39 eexpss-R720 gnome-shell[2185]: setup_framebuffers: assertion 'width > 0' failed 78884:Jan 25 15:47:39 eexpss-R720 gnome-shell[2185]: message repeated 8 times: [ setup_framebuffers: assertion 'width > 0' failed] I don't know if this tip `setup_framebuffers` is related to my extension.
JustPerfection waiting for author
Please ask that in GNOME Matrix channel: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions btw, you need to fix those indentation and unnecessary comments. It is hard to follow your lines. You wanna fix those warnings and then having it approved?
eexpss posted a review
I want keep those comment lines for future improve. please let it be. I will visit GNOME Matrix channel to solve those message issue.
eexpss posted a review
eexpss posted a review
I had read https://jsdoc.app/about-getting-started.html Those comment lines are only used for seperate. In order to make the function block look clearer, if they interfere with you, I will remove them. I have figure out the reason of `setup_framebuffers: assertion 'width > 0' failed`: I setup a `:hover` in css, maybe this affects the global style. When I press super key to show dock, those msg comes out. But I really need this setting to let `style-changed` signal emit. I call this signal 3 times in extension. Any other way to awake this signal?
JustPerfection posted a review
As @andyholmes mentioned on Matrix channel you can use `notify::hover`.
JustPerfection rejected
Newer version approved.