Review of "Lock Screen Message" version 1

Details Page Preview

Simple extension that let's you add your message to the lock screen (unlockDialog)

Extension Homepage
https://gitlab.com/AdvendraDeswanta/lock-screen-message

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Rejected because you are creating settings object in disable outside of that if block. You should do that inside that if block because when the extension is getting uninstalled you will create settings and setting will stay there until next login. 2. I see you mentioned the message will be destroied by unlock but since it a reverse process, you should destroy and null out `this._message` on enable. 3. Also do this on both enable and disable: ```js this.settings = null; ``` 4. If you add this to the metadata.json file you don't need to use any paramters for `ExtensionUtils.getSettings()`: ```json "settings-schema": "org.gnome.shell.extensions.lock-screen-message", ``` If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions