Review "M3U8 Play" version 1 - GNOME Shell Extensions

Review of "M3U8 Play" version 1

Details Page Preview

M3U8 Play

by eexpss

M3U8 Play. Search and select to play (use `ffplay/ffmpeg`). `m3u8` files need put into `~/.local/share/m3u8-play/`

Extension Homepage: https://github.com/eexpress/gs-m3u8-play/

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
9	Active
8	Rejected
7	Active
6	Rejected
5	Rejected
4	Inactive
3	Inactive
2	Inactive
1	Rejected

Previous Reviews on this Version

JustPerfection rejected February 16, 2022

1. You cannot use scripts (in your case spawn command) when you can do it in gjs: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#scripts-and-binaries Remove spawn command from line 30 and use Gio.File.copy: https://gjs-docs.gnome.org/gio20~2.66p/gio.file#method-copy 2. Log should only be available on debug mode: You can do: ```js debug = false; function lg(s){ if (debug) log("==="+GETTEXT_DOMAIN+"===>"+s); } ```