Review of "Cairo Clock" version 8

Details Page Preview

Cairo Clock. Click the clock face to set the alarm, click the center circle to enable the alarm. Alt + click on main icon, background of icon become green, this enable Popup per hour function. Ctrl + click on main icon, can test the alarm effect. In case of alarm, the clock will swing dynamically.

Extension Homepage
https://github.com/eexpress/gs-clock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
Timeout should be removed on disable (line 255 Clock.js)
eexpss posted a review
I had remove here: L257 GLib.Source.remove(timeoutClock); timeoutClock = null;
eexpss posted a review
Can I upload another one? I just add some little modify. But I don't know If still need remove the `timeoutClock` in extension.js.
JustPerfection posted a review
That's inside timeout callback. So it's like returning `GLib.SOURCE_REMOVE`. > You MUST remove all active main loop sources in disable(), even if the callback function will eventually return false or GLib.SOURCE_REMOVE. https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources