Review of "Hack" version 8

Details Page Preview

Add the Flip to Hack experience to the desktop

Extension Homepage
https://github.com/endlessm/eos-hack-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
11 Active
10 Rejected
9 Active
8 Rejected
7 Active
6 Active
5 Inactive
4 Inactive
3 Inactive
2 Inactive
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create objects in global scope which is the same as init (line 29 service.js, line 34 ui/wobblyFx.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Timeout should be removed on destroy or disable (line 127 ui/clubhouse.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 3. Use `ExtensionUtils.getSettings()` instead of (line 47 utils.js): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/f2c14a52071c1c73f87f020ff966d956737c085d/js/misc/extensionUtils.js#L185 4. What is the use case for `data/dbus-interfaces/.com.hack_computer.hack.xml.swp`? If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions