Review of "Icinga checker" version 13

Details Page Preview

Icinga/Nagios checker


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
24 Active
23 Active
22 Active
21 Active
20 Rejected
19 Rejected
18 Rejected
17 Active
16 Rejected
15 Active
14 Active
13 Rejected
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Timeout should be removed on disable (line 362 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 2. Also null out `Icinga` in disable. 3. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 4. I recommend to use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (supported on 3.34 and higher): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js Multi versioning is supported here, so don't worry about removing 3.32 and lower from metatada.json. 5. You cannot create objects in global scope which is the same as init (line 36 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization Move that line to enable and null out `settings` in disable. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions