Review of "Icinga checker" version 19

Details Page Preview

Icinga/Nagios checker


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
24 Active
23 Active
22 Active
21 Active
20 Rejected
19 Rejected
18 Rejected
17 Active
16 Rejected
15 Active
14 Active
13 Rejected
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Remove the timeout in disable (line 386 extension.js). 2. Use a less generic class name (line 23 prefs.js). 3. Please add GitHub or GitLab url to the metadata.json: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed 4. You cannot import gtk in shell process (extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gtk-and-gdk-imports 5. Please remove unnecessary comments. 6. Please remove the version from the import (line 32 extension.js). 7. No need to specify the id for `getSettings` (line 393 extension.js) since you specified that in metadata.json.