Review of "EasyScreenCast" version 42

Details Page Preview

This extension simplifies the use of the video recording function integrated in gnome shell, allows quickly to change the various settings of the desktop recording. SOURCE CODE -> https://github.com/EasyScreenCast/EasyScreenCast VIDEO -> https://youtu.be/81E9AruraKU **NOTICE** if an error occurs during the update is recommended to reload GNOME Shell (Alt + F2, 'r') and reload the extension's installation page.

Extension Homepage
https://github.com/EasyScreenCast/EasyScreenCast

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
Thanks for fixing those issues. 1. Just noticed about `new Gio.FileIcon()` in convenience.js and settings in (settings.js). Please check other files too, I may missed other ones. You cannot create objects in global scope which is the same as init: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization We are against those because: For example, when you fill `settings` which is in global scope, it won't be null after disable. That's not good, because the object remains there without any reason. Also the callbacks for signals can get triggered while the extension is disabled. This is not only an error but also a security risk in some cases, since extension is disabled on lock screen. So objects should be created in `enable()` process and null out in `disable()` process. 2. Please remove package.json: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files
Andreas Dangel posted a review
Thanks for the instant review! I'll upload a new version.