Review of "Random Wallpaper" version 29

Details Page Preview

Load new desktop wallpapers from various online sources with ease! Features: Various configurable wallpaper sources --> Unsplash --> Wallhaven --> Reddit --> Basically any JSON API/File (Examples) ----> Chromecast Images ----> NASA Picture of the day ----> Bing Picture of the day ----> Google Earth View --> Local folders --> Static URLs Multiple sources to create a pool of sources History of previous images --> Save your favourite wallpaper --> Add images to a block list Set the lock screen background Timer based renewal (Auto-Fetching) --> Load a new wallpaper on startup --> Pause the timer when desired Support for multiple monitors using third party tools --> Hydra Paper --> Superpaper Execute a custom command after every new wallpaper

Extension Homepage
https://github.com/ifl0w/RandomWallpaperGnome3

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
34 Active
33 Rejected
32 Active
31 Active
30 Active
29 Rejected
28 Active
27 Active
26 Active
25 Active
24 Active
23 Rejected
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Rejected
14 Active
13 Active
12 Rejected
11 Active
10 Active
9 Active
8 Active
7 Inactive
6 Rejected
5 Rejected
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
I just reviewed all of the files instead of diff: 1. Please remove unnecessary Lang imports. 2. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 3. Also do this in disable: ```js logger = null; wallpaperController = null; panelMenu = null; ``` 4. Log should be only available in debug mode. Please fix that in `logger.js` https://gjs.guide/extensions/review-guidelines/review-guidelines.html#no-excessive-logging 5. You should also null out `_afTimerInstance` in `cleanup()` (line 108 timer.js). We don't want the object remain there after disable. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
iflow.space posted a review
Hey! Thank you for the detailed feedback! I'll need a few days until I find time to incorporate these changes. I know that there is a lot of legacy code and the code quality is far from optimal. So, I really appreciate your feedback and the time you spent investigating all the files!