Review of "Kubectl Extension" version 5

Details Page Preview

Quick panel access to kubernetes resources utilizing kubectl CLI

Extension Homepage
https://github.com/cinatic/kubectl-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
14 Rejected
13 Rejected
12 Rejected
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create objects in global scope which is the same as init (line 99 helpers/settings.js, line 8 helpers/eventHandler.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 3. Remove the timeouts on destroy (line 149 components/screens/defaultDetailsScreen/defaultDetailsScreen.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 4. Also null out `kubectlMenu` in disable (extension.js). If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions