Review of "Kubectl Extension" version 12

Details Page Preview

Quick panel access to kubernetes resources utilizing kubectl CLI

Extension Homepage
https://github.com/cinatic/kubectl-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
14 Rejected
13 Rejected
12 Rejected
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. No need for line 22-43 (helpers/components.js). We have `setTimeout()` and `clearTimeout()` by default. 2. Timeout should be removed on destroy or disable (line 31 helpers/subprocess.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 3. Please use `TextDecoder` instead of `byteArray` (line 3 helpers/data.js): https://developer.mozilla.org/en-US/docs/Web/API/TextDecoder 4. Please don't use `imports` (line 1 helpers/eventHandler.js). You can use the new way: https://gjs.guide/extensions/upgrading/gnome-shell-43.html#signals and import it with: ```js import * as Util from 'resource:///org/gnome/shell/misc/signals.js'; ```
cinatic posted a review
Thanks for your feedback Regarding No. 2. after some considerations, i think it's not good to cancel this one, let's imagine gnome shuts down or whatever will trigger a destroy and i remove this particular timeout, then the underlying Gio Execution might block further I think those are similiar cases: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/ui/layout.js#L762 https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/ui/status/bluetooth.js#L135
JustPerfection posted a review
You should still remove the timeout on disable. In case you don't want the block, you can cancel it after removing the timeout.