Review "Stocks Extension" version 22 - GNOME Shell Extensions

Review of "Stocks Extension" version 22

Details Page Preview

Stocks Extension

by cinatic

Stocks Extension brings stock quotes to your GNOME Shell Panel

Extension Homepage: https://github.com/cinatic/stocks-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
35	Rejected
34	Rejected
33	Rejected
32	Active
31	Rejected
30	Active
29	Active
28	Active
27	Rejected
26	Rejected
25	Active
24	Active
23	Rejected
22	Rejected
21	Rejected
20	Rejected
19	Active
18	Active
17	Active
16	Rejected
15	Active
14	Active
13	Rejected
12	Active
11	Rejected
10	Active
9	Active
8	Active
7	Rejected
6	Active
5	Rejected
4	Active
3	Rejected
2	Rejected
1	Rejected

Previous Reviews on this Version

JustPerfection rejected April 18, 2022

1. Timeout should be remove on destroy (line 82 components/stocks/menuStockTicker.js). That callback can get triggered after disable. 2.Forgot to null out `stocksMenu` in disable. Add this to disable (extension.js): ```js stocksMenu = null; ``` 3. `SETTINGS_SCHEMA_DOMAIN` is unused. Remove it from `helpers/settings.js` (line 17).